Re: [PATCH v3 4/5] xen/arm: Move static memory build code in separate modules

[Luca Fancellu]

> On 9 Nov 2023, at 11:14, Michal Orzel <michal.or...@amd.com> wrote:
> 
> Hi Luca,
> 
> On 09/11/2023 10:06, Luca Fancellu wrote:
>> 
>> 
>> Move static memory and static shared memory code in separate modules
>> so that they are included only when the corresponding feature is
>> enabled, doing that we modularise the features and we remove some
>> ifdefs from the code to improve readability.
>> 
>> Move process_shm_node function from bootfdt module and make it
>> externally visible.
> What about process_domain_node()? This function is related to "xen,domain"
> compatible that is only present for dom0less domUs.

I see it a bit tricky to do, in fact putting it on the static-memory module 
would need to have it
externally visible from its module, but also it needs to have 
device_tree_get_meminfo
externally visible from the bootfdt.

I think that one is more a glue-code mostly related to dt and this cross 
dependency suggests me to
keep it as it is.

Cheers,
Luca