On 23.08.2023 05:03, Stewart Hildebrand wrote: > On 8/22/23 08:53, Jan Beulich wrote: >> On 22.08.2023 03:29, Stewart Hildebrand wrote: >>> --- a/xen/include/xen/pci.h >>> +++ b/xen/include/xen/pci.h >>> @@ -193,11 +193,10 @@ int pci_mmcfg_read(unsigned int seg, unsigned int bus, >>> unsigned int devfn, int reg, int len, u32 *value); >>> int pci_mmcfg_write(unsigned int seg, unsigned int bus, >>> unsigned int devfn, int reg, int len, u32 value); >>> -int pci_find_cap_offset(u16 seg, u8 bus, u8 dev, u8 func, u8 cap); >>> -int pci_find_next_cap(u16 seg, u8 bus, unsigned int devfn, u8 pos, int >>> cap); >>> -int pci_find_ext_capability(int seg, int bus, int devfn, int cap); >>> -int pci_find_next_ext_capability(int seg, int bus, int devfn, int start, >>> - int cap); >>> +int pci_find_cap_offset(pci_sbdf_t sbdf, u8 cap); >>> +int pci_find_next_cap(pci_sbdf_t sbdf, u8 pos, int cap); >>> +int pci_find_ext_capability(pci_sbdf_t sbdf, int cap); >>> +int pci_find_next_ext_capability(pci_sbdf_t sbdf, int start, int cap); >> >> The remaining types want converting, too: Neither fixed-width nor plain int >> are appropriate here. (It's a few too many type adjustments to make, for me >> to offer doing so while committing.) > > Understood, I'm happy to make the change for v4. Is the following what you'd > expect it to look like? > > unsigned int pci_find_cap_offset(pci_sbdf_t sbdf, unsigned int cap); > unsigned int pci_find_next_cap(pci_sbdf_t sbdf, unsigned int pos, > unsigned int cap); > unsigned int pci_find_ext_capability(pci_sbdf_t sbdf, unsigned int cap); > unsigned int pci_find_next_ext_capability(pci_sbdf_t sbdf, unsigned int start, > unsigned int cap);
Yes, this looks correct. Thanks. Jan
