Hi Andrew, > -----Original Message----- > From: Andrew Cooper <[email protected]> > Subject: Re: [4.17?] Re: [PATCH] x86/HVM+shim: fix build > when !CONFIG_GRANT_TABLE > > On 01/12/2022 16:14, Henry Wang wrote: > >>> Thanks for investigating. > >>> > >>> Acked-by: Andrew Cooper <[email protected]> > >> Thanks. > >> > >>> Thoughts about inclusion into 4.17? This is a build time regression vs > >>> 4.16. > >> I thought this was odd enough a configuration, but since you ask, let me > >> forward the question to Henry. > > I think a build time regression should be fixed. We cannot assume users > > will not use this configuration (as Jan pointed out in IRC). So for 4.17: > > > > Release-acked-by: Henry Wang <[email protected]> > > > > But if OSSTest is exploded after merging this patch, I would like to request > > a revert since we don't have too much time left for the due date. Hopefully > > everyone is fine with that. > > It is very unlikely that people are going have a configuration like this > in production. > > But, the 4.17 branch does have Gitlab CI running on it, including > randconf tests, which provably do spot the error occasionally. > > The (IMO better) justification to take it into 4.17 at this point is to > fix a CI failure.
Good point, my release ack is still valid :) Kind regards, Henry > > ~Andrew
