Hi Jan and Andrew, > -----Original Message----- > From: Jan Beulich <[email protected]> > Subject: [4.17?] Re: [PATCH] x86/HVM+shim: fix build > when !CONFIG_GRANT_TABLE > > On 01.12.2022 17:01, Andrew Cooper wrote: > > On 01/12/2022 15:57, Jan Beulich wrote: > >> The HVM flavor of the hypercall handlers exists only when GRANT_TABLE > is > >> enabled, while surrogate shim variants exist only for the purpose of PV. > >> (Also scratch out the Arm variant in that case; what exactly is used in > >> that cell of the new table row doesn't really matter.) > >> > >> Fixes: 8523851dbc49 ("xen/x86: call hypercall handlers via generated > macro") > >> Signed-off-by: Jan Beulich <[email protected]> > >> Reported-by: Andrew Cooper <[email protected]> > > > > Thanks for investigating. > > > > Acked-by: Andrew Cooper <[email protected]> > > Thanks. > > > Thoughts about inclusion into 4.17? This is a build time regression vs > > 4.16. > > I thought this was odd enough a configuration, but since you ask, let me > forward the question to Henry.
I think a build time regression should be fixed. We cannot assume users will not use this configuration (as Jan pointed out in IRC). So for 4.17: Release-acked-by: Henry Wang <[email protected]> But if OSSTest is exploded after merging this patch, I would like to request a revert since we don't have too much time left for the due date. Hopefully everyone is fine with that. Kind regards, Henry > > Jan
