On Thu, Oct 20, 2022 at 10:30:26AM +0000, Henry Wang wrote: > Hi Roger, > > > -----Original Message----- > > From: Roger Pau Monne <[email protected]> > > Subject: [PATCH for-4.17?] test/vpci: enable by default > > > > CONFIG_HAS_PCI is not defined for the tools build, and as a result the > > vpci harness would never get build. Fix this by building it > > unconditionally, there's nothing arch specific in it. > > > > Reported-by: Andrew Cooper <[email protected]> > > Signed-off-by: Roger Pau Monné <[email protected]> > > --- > > While not strictly a bugfix, I think it's worth adding this change to the > > release in order to always build the vpci test hardness and prevent it > > from bitrotting. > > Good point. > > No problem from my side, but I think you need also Anthony's opinion > as he is the toolstack maintainer.
This sounds fine to me, the risk is that the build could fail. But we can easily revert the patch and reapply it at the next development cycle. Acked-by: Anthony PERARD <[email protected]> Thanks, -- Anthony PERARD
