Hi Roger, > -----Original Message----- > From: Roger Pau Monne <[email protected]> > Subject: [PATCH for-4.17?] test/vpci: enable by default > > CONFIG_HAS_PCI is not defined for the tools build, and as a result the > vpci harness would never get build. Fix this by building it > unconditionally, there's nothing arch specific in it. > > Reported-by: Andrew Cooper <[email protected]> > Signed-off-by: Roger Pau Monné <[email protected]> > --- > While not strictly a bugfix, I think it's worth adding this change to the > release in order to always build the vpci test hardness and prevent it > from bitrotting.
Good point. No problem from my side, but I think you need also Anthony's opinion as he is the toolstack maintainer. If he also likes this idea, feel free to add my: Release-acked-by: Henry Wang <[email protected]> Kind regards, Henry > --- > tools/tests/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/tests/Makefile b/tools/tests/Makefile > index 33e32730c4..d99146d56a 100644 > --- a/tools/tests/Makefile > +++ b/tools/tests/Makefile > @@ -10,7 +10,7 @@ SUBDIRS-$(CONFIG_X86) += x86_emulator > endif > SUBDIRS-y += xenstore > SUBDIRS-y += depriv > -SUBDIRS-$(CONFIG_HAS_PCI) += vpci > +SUBDIRS-y += vpci > > .PHONY: all clean install distclean uninstall > all clean distclean install uninstall: %: subdirs-% > -- > 2.37.3
