On 09.06.2022 12:16, Bertrand Marquis wrote: >> On 1 Jun 2022, at 17:59, Anthony PERARD <[email protected]> wrote: >> >> Use "define" for the headers*_chk commands as otherwise the "#" >> is interpreted as a comment and make can't find the end of >> $(foreach,). >> >> Adding several .PRECIOUS as without them `make` deletes the >> intermediate targets. This is an issue because the macro $(if_changed,) >> check if the target exist in order to decide whether to recreate the >> target. >> >> Removing the call to `mkdir` from the commands. Those aren't needed >> anymore because a rune in Rules.mk creates the directory for each >> $(targets). >> >> Remove "export PYTHON" as it is already exported. > > With this change, compiling for x86 is now ending up in: > CHK include/headers99.chk > make[9]: execvp: /bin/sh: Argument list too long > make[9]: *** [include/Makefile:181: include/headers++.chk] Error 127 > > Not quite sure yet why but I wanted to signal it early as other might be > impacted. > > Arm and arm64 builds are not impacted.
Hmm, that patch has passed the smoke push gate already, so there likely is more to it than there being an unconditional issue. I did build-test this before pushing, and I've just re-tested on a 2nd system without seeing an issue. Also please remember to trim your replies. Jan
