On 06.06.2022 15:39, Anthony PERARD wrote: > On Thu, Jun 02, 2022 at 11:11:15AM +0200, Jan Beulich wrote: >> On 01.06.2022 18:59, Anthony PERARD wrote: >>> Use "define" for the headers*_chk commands as otherwise the "#" >>> is interpreted as a comment and make can't find the end of >>> $(foreach,). >> >> In cmd_xlat_lst you use $(pound) - any reason this doesn't work in >> these rules? Note that I don't mind the use of "define", just that I'm >> puzzled by the justification. > > I think I just forgot about $(pound) when I tried to debug why the > command didn't work in some environment (that is when not using define). > > I think the second thing that make me not replacing '#' by "$(pound)" is > that reading "#include" in the Makefile is probably better that > reading "$(pound)include". > > I guess we should add something to the justification like: > That allow us to keep writing "#include" in the Makefile without > having to replace that by "$(pound)include" which would be a bit > less obvious about the command line purpose.
I'd be okay with this, and I'd also be okay with adding this while committing. With it added Acked-by: Jan Beulich <[email protected]> Jan
