On Wed, Jun 01, 2022 at 05:59:08PM +0100, Anthony PERARD wrote: > diff --git a/xen/tools/compat-xlat-header b/xen/tools/compat-xlat-header > new file mode 100755 > index 0000000000..f1f42a9dde > --- /dev/null > +++ b/xen/tools/compat-xlat-header > @@ -0,0 +1,539 @@ > +#!/usr/bin/perl -w > + > +use strict; > +use warnings;
I hope to take more of a look at this, but one thing I immediately notice: -w is redundant with "use warnings;". I strongly prefer "use warnings;", but others may have different preferences. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | [email protected] PGP 87145445 | ) / \_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
