On 01/06/2022 17:59, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git > br.build-system-xen-include-rework-v1 > > Hi, > > This patch series is about 2 improvement. First one is to use $(if_changed, ) > in "include/Makefile" to make the generation of the compat headers less > verbose > and to have the command line part of the decision to rebuild the headers. > Second one is to replace one slow script by a much faster one, and save time > when generating the headers. > > Thanks. > > Anthony PERARD (4): > build: xen/include: use if_changed > build: set PERL > build: replace get-fields.sh by a perl script > build: remove auto.conf prerequisite from compat/xlat.h target > > xen/Makefile | 1 + > xen/include/Makefile | 106 ++++--- > xen/tools/compat-xlat-header | 539 +++++++++++++++++++++++++++++++++++ > xen/tools/get-fields.sh | 528 ----------------------------------
Excellent. I was planning to ask you about this. (I also need to refreshing my half series cleaning up other bits of the build.) One trivial observation is that it would probably be nicer to name the script with a .pl extension. Any numbers on what the speedup in patch 3 is? Are the generated compat headers identical before and after this series? If yes, I'm very tempted to ack and commit it straight away. ~Andrew
