Hi James,
On Tue, Mar 01, 2022 at 09:35:13AM +0000, James Dingwall wrote:
> The set_mtu() function of xen-network-common.sh currently has this code:
>
> if [ ${type_if} = vif ]
> then
> local dev_=${dev#vif}
> local domid=${dev_%.*}
> local devid=${dev_#*.}
>
> local FRONTEND_PATH="/local/domain/$domid/device/vif/$devid"
>
> xenstore_write "$FRONTEND_PATH/mtu" ${mtu}
> fi
>
> This works fine if the device has its default name but if the xen config
> defines the vifname parameter the FRONTEND_PATH is incorrectly constructed.
> Learn the frontend path by reading the appropriate value from the backend.
The patch looks fine, thanks. It is only missing a line
"Signed-off-by: your_name <your_email>" at the end of the description.
The meaning of this line is described in the file CONTRIBUTING, section
"Developer's Certificate of Origin".
Thanks,
--
Anthony PERARD