Hi Michal, > On 22 Feb 2022, at 07:07, Michal Orzel <[email protected]> wrote: > > Hi Julien, > > On 21.02.2022 16:58, Julien Grall wrote: >> Hi Michal, >> >> On 21/02/2022 10:59, Michal Orzel wrote: >>> Following a discussion [1] it seems like that renaming work has >>> been forgotten. >> >> This is in my todo list of clean-up I need to do for Xen. But I haven't yet >> had a chance to look at it. Thank you for taking a look! >> >>> Perform renaming of psr_mode_is_32bit to >>> regs_mode_is_32bit as the function no longer takes psr parameter. >> >> If we modify psr_mode_is_32bit(), then we should also modify >> psr_mode_is_user() because they have the same prototype and we should keep >> the naming consistent. >> > Ok, I agree. Do you think this should be done in a separate patch? > FWICS, psr_mode_is_user is used in traps.c, vcpreg.c ,vtimer.c and vsysreg.c > whereas psr_mode_is_32bit - only in traps.c.
I think it can be done in a separate patch. Cheers Bertrand > >>> >>> [1] https://marc.info/?l=xen-devel&m=156457538423787&w=2 >> >> NIT: The first sentence and this link adds value for the review on the >> mailing list (we know where the request came from) but doesn't add any after >> the commit message (there are no extra information in them). >> >> So I would move this information after ---. This will get dropped on commit. >> > Ok. >> Cheers, >> > > Cheers, > Michal >
