Hi Michal,
On 21/02/2022 10:59, Michal Orzel wrote:
Following a discussion [1] it seems like that renaming work has
been forgotten.
This is in my todo list of clean-up I need to do for Xen. But I haven't
yet had a chance to look at it. Thank you for taking a look!
Perform renaming of psr_mode_is_32bit to
regs_mode_is_32bit as the function no longer takes psr parameter.
If we modify psr_mode_is_32bit(), then we should also modify
psr_mode_is_user() because they have the same prototype and we should
keep the naming consistent.
[1] https://marc.info/?l=xen-devel&m=156457538423787&w=2
NIT: The first sentence and this link adds value for the review on the
mailing list (we know where the request came from) but doesn't add any
after the commit message (there are no extra information in them).
So I would move this information after ---. This will get dropped on commit.
Cheers,
--
Julien Grall
