On 17.09.2021 10:45, Andrew Cooper wrote: > * Delete trailing whitespace > * Replace an opencoded DIV_ROUND_UP() > * Drop bogus smp_rmb() - spin_lock_irqsave() has full smp_mb() semantics. > > Signed-off-by: Andrew Cooper <[email protected]>
Largely Reviewed-by: Jan Beulich <[email protected]> One remark: > @@ -717,9 +713,6 @@ void __trace_var(u32 event, bool_t cycles, unsigned int > extra, > if ( !cpumask_test_cpu(smp_processor_id(), &tb_cpu_mask) ) > return; > > - /* Read tb_init_done /before/ t_bufs. */ > - smp_rmb(); > - > spin_lock_irqsave(&this_cpu(t_lock), flags); > > buf = this_cpu(t_bufs); I wonder whether the comment wouldn't be helpful to move down here, in of course a slightly edited form (going from /before/ to /after/). Jan
