On Dec 22, 2007 10:37 PM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > hi, > > 2007/12/23, James Hawkins <[EMAIL PROTECTED]>: > > On Dec 22, 2007 6:57 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > > > James Hawkins schreef: > > > > > > > On Dec 22, 2007 12:25 PM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > > > > > > > >> 2007/12/23, James Hawkins <[EMAIL PROTECTED]> > > > >>>>> > > > > >>>> > > > >>> Disassembling what? > > > >>> > > > >> Native ole32.dll, MkParseDisplayName calls adsldp.dll's > > > >> DllGetClassObject twice, > > > >> frist using IID_IParseDisplayName, second using IID_IClassFactory. > > > >> > > > >> > > > >> > > > > > > > > Disassembling native Windows binaries is not allowed in this project, > > > > so I'm afraid none of your patches can be accepted > > > This is not the first time such disassemble occurs, I think it should be > > > made more clear that disassembly is not allowed in the wine project. > > Thank you for mentioning that. But, I think that's kind of mixing up. > I didn't do anything like disassembly code to source code translation. > I just saw how native binaries work when debugging my app in Windows. >
Disassembling of any kind is prohibited. You don't have to convert the disassembly to source code first to disqualify. > I didn't have much knowledge about COM, so I searched MSDN and found > some useful info about DllGetClassObject, then I wrote the patch, it's > quite clean. > You just said you disassembled native ole32.dll. -- James Hawkins