Hi Maciej, Thanks for your attention! > For reference: will the feature flag be comprehensive, or will parts of the implementation/scaffolding be outside the ifdef?
It should be comprehensive. So it will. Although some trivial inline stubs, like just returning null or false, or even doing nothing, will be outside the flag for minimizing if/def disturbance, they'll be optimized out by compilers. Also, some kind of refactoring might precede to make new features fit in the code. Such refactoring will be aimed to achieve clear separation of new additions by, for example, introducing better encapsulation. (Please note that this is just a general direction of the change. I have no concrete refactoring plan in my mind at this time.) As an example, here is the first bit of the change: https://bugs.webkit.org/attachment.cgi?id=185411&action=review I expect most of the code from this feature to grow under these CustomElementSomething and accompany classes. Hope this answers your question. -- morrita On Wed, Jan 30, 2013 at 4:52 PM, Maciej Stachowiak <[email protected]> wrote: > > On Jan 29, 2013, at 6:22 PM, Hajime Morrita <[email protected]> wrote: > > Hi folks, > > I'm going to implement "Custom Elements" standard behind > ENABLE(CUSTOM_ELEMENTS) flag. > https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/custom/index.html > > > For reference: will the feature flag be comprehensive, or will parts of > the implementation/scaffolding be outside the ifdef? > > - Maciej > > > Here is the tracking bug for the feature: > https://bugs.webkit.org/show_bug.cgi?id=99688 > > Note that Mozilla is also working on implementing this. > https://bugzilla.mozilla.org/show_bug.cgi?id=783129 > > Let me know if you have any questions or comments. > > Bests, > -- > morrita > > _______________________________________________ > webkit-dev mailing list > [email protected] > https://lists.webkit.org/mailman/listinfo/webkit-dev > > >
_______________________________________________ webkit-dev mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-dev
