I can see some downsides to emptying the cache before each test: - we won't be getting any test coverage for cache behavior when it hits non-trivial size;
- this may well make tests measurably slower; - this will be yet another cause of subtle difference between platforms, as some will undoubtedly have this unimplemented for a long time. - WBR, Alexey Proskuryakov 08.08.2012, в 10:47, Ojan Vafai написал(а): > See https://bugs.webkit.org/show_bug.cgi?id=93195. > > media/W3C/video/networkState/networkState_during_progress.html and > media/video-poster-blocked-by-willsendrequest.html are flaky on all platforms > because they behave differently if the loaded resource is cached. > > Every time I've taken a stab at reducing test flakiness, I've come across at > least a few tests that pass when run as part of the test suite, but fail when > run by themselves (or in parallel) because they accidentally expect an image > or something to be in the cache. > > I think it would make the tests more maintainable if we cleared the cache > before each test run. This is *not* before each page load though. So tests > that do multiple page loads will still test cross-navigation caching behavior. > > While it's true that we could one-off fix each of these tests, it's usually > very time consuming to figure out that caching is the problem, that's > assuming anyone takes the time to look into why the test is flaky in the > first place. > > Any objections? > > Ojan > _______________________________________________ > webkit-dev mailing list > [email protected] > http://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo/webkit-dev
