11.04.2010, в 12:34, Stephan Assmus написал(а): > Am I supposed to change the > review flag back to "r?" to get additional feedback for the same patch?
If you think that the review comment were all wrong, and the patch can still be landed as is, then marking it for review again is an appropriate thing to do. > So > far I thought that all people in the bug's CC list receive email > notifications for additional comments. Is this not the case? This is generally correct (it's possible to turn bugmail for comments off, but I don't think many reviewers do that). You don't necessarily need attention from the same people though - someone may feel qualified to r- a patch for certain reasons, but not to r+ it. > <https://bugs.webkit.org/show_bug.cgi?id=35288> This is definitely a case where you should flip the flag again. > <https://bugs.webkit.org/show_bug.cgi?id=34683> This bug currently has a patch marked for review. - WBR, Alexey Proskuryakov _______________________________________________ webkit-dev mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
