Hi, I would not mind if connector option is removed in next release. I found the issue while I was debugging my hotplug patches for ivi-shell.
But I also agree with Daniel that my patches are legitimate bugfixes. We can merge them this release and remove the option altogether in next release. Best regards Emre Ucan Software Group I (ADITG/SW1) > -----Original Message----- > From: Pekka Paalanen [mailto:[email protected]] > Sent: Montag, 6. Februar 2017 14:08 > To: Daniel Stone > Cc: Ucan, Emre (ADITG/SW1); [email protected] > Subject: Re: [PATCH weston 1/2] compositor-drm: update connectors with > connector config > > On Mon, 6 Feb 2017 12:19:45 +0000 > Daniel Stone <[email protected]> wrote: > > > Hi Pekka, > > > > On 6 February 2017 at 12:00, Pekka Paalanen <[email protected]> > wrote: > > > On Mon, 6 Feb 2017 11:05:51 +0000 > > > Daniel Stone <[email protected]> wrote: > > >> I think we've got to choose between fixing it for 1.13 and removing it > > >> immediately after release (which I will happily do), or just ripping > > >> it out now. > > > > > > I believe it works already as well as it ever has. Therefore any change > > > to how it works is something no user has ever seen before. > > > > > > I reviewed update_outputs() from Weston 1.10 release (a random pick) > > > and it seems that too uses --connector only for start-up, and never for > > > hotplug. The same for Weston 1.7, so I believe it has never worked any > > > better. > > > > > > If --connector didn't work *at all* currently, then I'd agree on just > > > removing it right now. OTOH, I have seen notes that --connector has > > > actually been used in the wild, which is why I'd say it's a major > > > feature to remove: it has a risk of user-visible breakage (unknown > > > command line option). > > > > OK, fair enough. I'd suggest we: > > - merge Emre's two patches as legitimate bugfixes > > - document --connector as deprecated in NEWS for 2.0 (must stop typing > 1.13) > > - remove it for 2.1 (or 3.0 or whatever) > > > > How's that sound? For the record, these two patches are: > > Acked-by: Daniel Stone <[email protected]> > > If you want to merge them, that's fine. I just wont bother myself. > > > Thanks, > pq _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
