On Mon, 6 Feb 2017 11:05:51 +0000 Daniel Stone <[email protected]> wrote:
> Hi, > > On 6 February 2017 at 10:29, Pekka Paalanen <[email protected]> wrote: > > On Thu, 2 Feb 2017 14:06:55 +0000 > > "Ucan, Emre (ADITG/SW1)" <[email protected]> wrote: > >> weston can be started with --connector option to be initialized > >> with a particular output. But in the update_outputs this option > >> is not considered and output is created for all the available > >> connectors. This patch fixes this issue by considering > >> the option for connectors in the update_outputs. > > > > I would much rather see the whole --connector option removed than > > anything to make it work "better". > > > > This is because the option works by DRM connector IDs, which a) are > > very hard to find out and b) not guaranteed to be fixed. So it's really > > just a debugging option that has outlived its purpose by five years or > > so, IMO. I think it also gives a wrong impression about b). > > I cannot agree more. > > > The modern way of defining connector states is weston.ini with its > > [output] sections. We still don't have a way to specify the default > > behaviour to "off" instead of "use the default/current mode". If such > > an option is needed, I would be happy to see one added to weston.ini > > where one could define the default behaviour for outputs not matched by > > any named [output] section. Besides, this could be implemented already > > with the libweston output configuration API in main.c. > > That would be a nice addition, yeah. > > > Unfortunately, I consider the removal of --connector option a "major > > feature", which means we can't do it anymore on this release cycle. > > Depends. If it's been broken throughout the entire cycle (three weeks > since 1.12 release), you could make an argument that we effectively > removed it then, and this is just a cleanup. You could probably even > mostly keep a straight face whilst doing so. > > I think we've got to choose between fixing it for 1.13 and removing it > immediately after release (which I will happily do), or just ripping > it out now. Hi Daniel, I believe it works already as well as it ever has. Therefore any change to how it works is something no user has ever seen before. I reviewed update_outputs() from Weston 1.10 release (a random pick) and it seems that too uses --connector only for start-up, and never for hotplug. The same for Weston 1.7, so I believe it has never worked any better. If --connector didn't work *at all* currently, then I'd agree on just removing it right now. OTOH, I have seen notes that --connector has actually been used in the wild, which is why I'd say it's a major feature to remove: it has a risk of user-visible breakage (unknown command line option). Thanks, pq
pgpQfNk38O1Ji.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
