On Mar 18, 2014 2:09 PM, "Bryce W. Harrington" <[email protected]> wrote: > > On Mon, Mar 17, 2014 at 11:34:50AM +0800, Quanxian Wang wrote: > > This event contains name of output. It may be sent after > > binding the output object. It is intended that client could > > input a character output name as a parameter or for log output. > > > > Signed-off-by: Quanxian Wang <[email protected]> > > --- > > protocol/wayland.xml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/protocol/wayland.xml b/protocol/wayland.xml > > index d47ee62..0332e1a 100644 > > --- a/protocol/wayland.xml > > +++ b/protocol/wayland.xml > > @@ -1756,6 +1756,17 @@ > > </description> > > <arg name="factor" type="int" summary="scaling factor of output"/> > > </event> > > + > > + <event name="name" since="3">
You also need to bump the version field on the wl_output interface > > + <description summary="output name properties"> > > + This event contains name of output. It may be sent after > > + binding the output object. It will provide useful name > > + for client when they generate the log for user. > > + Also it is intended that client could input a character > > + output name as a parameter or log. > > Fixing up the grammar a bit: > > """ > This event contains the name of the output. It may be sent after > binding the output object. It will provide a useful name for the > client when it generates the log for the user. Also, it is intended > that the client could input a character output name as a parameter or > log. > """ > > If I understand the purpose of this patchset properly, this might be > clearer phrasing: > > """ > This event allows assigning a human-readable alias to an output; it may > be sent after binding the output object. It is intended that the client > can use this output name as a parameter or display it in logs. > """ > > I glanced at the other patches and they look technically correct, but I > think what might be missing here is a stronger justification about why > this is needed? While I kind of like the idea of a human-readable name, I agree with Bryce that some justification is needed. Thanks, Jason Ekstrand > > > + </description> > > + <arg name="name" type="string" summary="name of output"/> > > + </event> > > </interface> > > > > <interface name="wl_region" version="1"> > > -- > > 1.8.1.2 > > > > _______________________________________________ > > wayland-devel mailing list > > [email protected] > > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
_______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
