From: Jason Ekstrand [mailto:[email protected]] Sent: Saturday, March 15, 2014 9:10 PM To: Wang, Quanxian Cc: [email protected]; [email protected] Subject: RE: [PATCH 2/3] weston:Add wl_output name event
On Mar 15, 2014 4:57 AM, "Wang, Quanxian" <[email protected]<mailto:[email protected]>> wrote: > > > > > > From: Jason Ekstrand > [mailto:[email protected]<mailto:[email protected]>] > Sent: Saturday, March 15, 2014 3:54 AM > To: Wang, Quanxian > Cc: [email protected]<mailto:[email protected]>; > [email protected]<mailto:[email protected]> > > Subject: Re: [PATCH 2/3] weston:Add wl_output name event > > > > > On Mar 13, 2014 9:12 PM, "Quanxian Wang" > <[email protected]<mailto:[email protected]>> wrote: > > > > Signed-off-by: Quanxian Wang > > <[email protected]<mailto:[email protected]>> > > --- > > src/compositor.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/src/compositor.c b/src/compositor.c > > index 98a4f6f..8e8964b 100644 > > --- a/src/compositor.c > > +++ b/src/compositor.c > > @@ -3045,6 +3045,9 @@ bind_output(struct wl_client *client, > > } > > > > if (version >= 2) > > + wl_output_send_name(resource, output->name); > > As with my comment on the protocol, wl_output_send_name should be version 3, > not version 2. That should also clear up Bryce's comment. > > [Wang, Quanxian] if it is 2, patch 3/3 is not needed because currently shell > only support version 2. Right? We should still have patch 3 since weston should always support the latest version of everything. [Wang, Quanxian]That is fine according to my testing. If no patch 3/3, desktop-shell will crash. I am not sure if more updates are needed. For example, in our shell code, we use such code min(2, version) for wl_output interface, should we change it to minal(3,version) if merge this patch? > > Thanks, > --Jason Ekstrand > > > + > > + if (version >= 2) > > wl_output_send_done(resource); > > } > > > > -- > > 1.8.1.2 > > > > _______________________________________________ > > wayland-devel mailing list > > [email protected]<mailto:[email protected]> > > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
_______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
