On Mon, 16 Mar 2026 20:39:53 GMT, Ivan Walulya <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update log messages when poking the system dictionary
>
> src/hotspot/share/classfile/classFileParser.cpp line 6321:
>
>> 6319: }
>> 6320:
>> 6321: void ClassFileParser::preload_classes(ConstantPool* cp, TRAPS) {
>
> If we check `PreloadClasses` at the call-sites, then just assert
> `precond(PreloadClasses)` here, might improve the code.
>
> or return early if `!PreloadClasses`
I think we can still do a system dictionary lookup and flatten even when
preloading is not enabled.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2228#discussion_r2942895074
