On Mon, 16 Mar 2026 19:49:31 GMT, Frederic Parain <[email protected]> wrote:
>> This patch removes the mandatory preloading triggered by the @NullRestricted
>> annotated fields, and falls back to the speculative pre-loadings allowed by
>> the LoadableDescriptors attribute.
>> See the CR for more details about the rational and the new semantic of the
>> @NullRestricted annotation.
>>
>> Tested with Mach5 tier1-4.
>>
>> Thank you.
>
> Frederic Parain has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update log messages when poking the system dictionary
Changes requested by iwalulya (no project role).
src/hotspot/share/classfile/classFileParser.cpp line 6321:
> 6319: }
> 6320:
> 6321: void ClassFileParser::preload_classes(ConstantPool* cp, TRAPS) {
If we check `PreloadClasses` at the call-sites, then just assert
`precond(PreloadClasses)` here, might improve the code.
or return early if `!PreloadClasses`
-------------
PR Review:
https://git.openjdk.org/valhalla/pull/2228#pullrequestreview-3956543941
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2228#discussion_r2942859257
