On Mon, 16 Mar 2026 07:04:14 GMT, Stefan Karlsson <[email protected]> wrote:
>> Paul Hübner has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update src/hotspot/share/runtime/arguments.cpp >> >> Co-authored-by: Stefan Karlsson <[email protected]> >> - Update src/hotspot/share/opto/parse2.cpp >> >> Co-authored-by: Stefan Karlsson <[email protected]> > > test/hotspot/jtreg/compiler/valhalla/inlinetypes/InlineTypes.java line 41: > >> 39: "--add-exports", >> "java.base/jdk.internal.vm.annotation=ALL-UNNAMED", >> 40: "--add-exports", >> "java.base/jdk.internal.misc=ALL-UNNAMED", >> 41: "-XX:+UnlockDiagnosticVMOptions", > > Unrelated to this PR, but I saw this flag: > "-XX:+IgnoreUnrecognizedVMOptions", > > I would consider removing from all the tests as a follow-up PR. We've been > bitten by that flag so many times in our testing that we shouldn't use it at > all, unless there's a written motivation why it is needed. My 2c. Fair point, seems like a very slippery slope indeed. I've filed [JDK-8380140](https://bugs.openjdk.org/browse/JDK-8380140) for compiler since they're the only ones who use the flag in Valhalla. Let's have them take a look and make an informed decision. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2226#discussion_r2939358241
