On Mon, 16 Mar 2026 06:58:18 GMT, Stefan Karlsson <[email protected]> wrote:
>> Paul Hübner has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update src/hotspot/share/runtime/arguments.cpp >> >> Co-authored-by: Stefan Karlsson <[email protected]> >> - Update src/hotspot/share/opto/parse2.cpp >> >> Co-authored-by: Stefan Karlsson <[email protected]> > > src/hotspot/share/runtime/arguments.cpp line 3884: > >> 3882: #define WARN_IF_NOT_DEFAULT_FLAG(flag) >> \ >> 3883: if (!FLAG_IS_DEFAULT(flag)) { >> \ >> 3884: warning("Preview-specific flag \"%s\" has no effect when >> --enable-preview is not specified.", #flag); \ > > Is this done because we don't want to mention Valhalla to the users? It's less that we want to explicitly _hide_ Valhalla, it's more that we've transitioned from Valhalla vs non-Valhalla to preview vs non-preview, so our warnings should reflect that as well. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2226#discussion_r2939300036
