In qemu-hwe, what bug is this change fixing?

--- a/debian/hwe-helper/99-ubuntu-virt.conf
+++ b/debian/hwe-helper/99-ubuntu-virt.conf
@@ -1,4 +1,6 @@
 DPkg::Pre-Install-Pkgs {
-  "test -x /usr/bin/apt_hook_ubuntu_virt && /usr/bin/apt_hook_ubuntu_virt || 
true";
+  "/usr/bin/apt_hook_ubuntu_virt || true";
 };
+// apt keys DPkg::Tools::options::<key>::Version is the first word
+// (up to the first space),so we can skip the "|| true" part
 DPkg::Tools::options::/usr/bin/apt_hook_ubuntu_virt::Version "2";


In d/changelog we only have:

  * d/hwe-helper/99-ubuntu-virt.conf: Fix version setting for the hook
script

Less importantly, because there is no code change, but what does the
comment mean? Which "|| true" part is being skipped? Perhaps you meant
"so we can skip the test -x part"?

And what's the impact of removing the "test -x" prefix if the hook isn't
there? Won't we get a "command not found" or something sent to stderr or
even stdout? I understand that "|| true" will guard against this
returning non-zero, but what about the output?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2164849

Title:
  purging libvirt-daemon when libvirt-daemon-hwe is installed breaks
  libvirt-daemon-hwe

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/edk2/+bug/2164849/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to