Thanks for summarizing the discussion Lukas.

We totally want to give users a way to change, and while there is by
changing /etc/profile.d/libvirt-uri.sh now that the conf exists that
seems nicer. Anyone can keep the old way on upgrade.

I just realized we might as well look for dropping the export entirely,
but retain behavior.

AFAICS in ./src/libvirt.conf the default still is and it should on
Ubuntu be "qemu:///system".

Docs at https://libvirt.org/uri.html#default-uri-choice say:
If the URI passed to virConnectOpen* is NULL or empty string, then libvirt will 
use the following logic to determine what URI to use.
1. The environment variable LIBVIRT_DEFAULT_URI
2. The client configuration file uri_default parameter
3. Probe each hypervisor in turn until one that works is found

Maybe we just change our /etc/libvirt.conf to an uncommented uri_default = 
"qemu:///system" ?
And drop having /etc/profile.d/libvirt-uri.sh ?
When changing the default to be explicit in /etc/libvirt.conf we could point to 
a NEWS entry and there explain old vs new.

That would have the same effect.
!IF! a user overwritten it in a ~/.../libvirt.conf it is their choice and we 
want to obey.
This would also make it work in environments without login shells (hence 
behavior is slightly different and we would not SRU it, but that is fine).

And setting the default that way would then make it work the same in
Ubuntu as upstream documents it.

I feel we are going in circles and we had that but ruled it out in the
past, what am I missing in my thoughts?

This made me spend more time on this and I realized that we indeed went
full circle, but in a positive way. That is just what was suggested
initially and the conclusion we had up to comment #7.

So the bad thing is that it fell through the cracks from there and got lost for 
too long, our bad, sorry.
But other than that - the most simple solution might be the one.
Quoting our old goal of comment #7
  "full removal of the script while making sure qemu:///system remains as the 
default uri_default"

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2027838

Title:
  /etc/profile.d/libvirt-uri.sh (LIBVIRT_DEFAULT_URI setting) overrides
  configured default

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/2027838/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to