I'm trying to review this as part of a patch-pilot shift. It looks from comments as though the other reviewers queries have been addressed, but I'm having trouble reconciling the debdiff to the stated changes. For instance:
* Pin Go toolchain to 1.23.8 ... I can't see 1.23.8 anywhere in the plucky debdiff outside of the changelog. I'm not that familiar with golang, but am I wrong in thinking go.mod should have "go 1.23.8" near the top? Also, this is an SRU but it incorporates a full version bump. That sort of thing normally involves a package-specific agreement with the SRU team, but I don't see wsl-pro-services mentioned under the package specific notes[1] of the SRU docs. Are the SRU team okay with this? In the meantime I'm unsubscribing ubuntu-sponsors; please re-subscribe when the points above are addressed. [1]: https://documentation.ubuntu.com/sru/en/latest/reference/package- specific/#reference-package-specific-notes -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2106757 Title: [SRU] wsl-pro-service version 0.1.18 for Questing, Plucky, Oracular and Noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wsl-pro-service/+bug/2106757/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
