python-kde review:

- Detailled explanation of the changes in the changelog, please.
- no updated build/binary dependencies for the new kdelibs API?
- Why is the configure.py change necessary and why was the code commented out 
before?
- The konsole_part.sip looks strange to me: it seems that this just converts 
the 3.4.1 version to the 3.5.2 version, but that (a) certainly does not reflect 
the changes in kdelibs/kdebase (which just got the new 'pass pty through fd' 
feature added) and (b) seems much more intrusive than necessary.  Shouldn't it 
be enough to add the new setPty() function to the interface? In any case this 
is certainly not a minimal diff.

-- 
SRU: updates necessary for Kubuntu Upgrade Tool in Edgy
https://launchpad.net/bugs/84717

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to