Hi Andre, On 01:40 Fri 02 Jan , Andre Przywara wrote: > On Sun, 30 Nov 2025 21:45:10 +0000 > Yixun Lan <[email protected]> wrote: > > Hi Yixun, > > thanks for updating this series, and sorry for the delay in the review. > > As for this patch: it should go to the end of the series, since it > already introduces the possibility to select the new SoC, even though > the rest of the code isn't ready yet. And I think we should drop the > "select SUPPORT_SPL", since it's not really supported, without the DRAM see my comment in other thread
> code. If we rely on FEL to load U-Boot anyway, we can much simpler load > TF-A and U-Boot proper directly, no need for any FIT image. I haven't went the way to lod TF-A, U-Boot separately even use FEL, but insted, still follow previous traditionl way - combine all images together, that's TF-A, SPL, U-Boot.. for this reason I'd just keep configurations of SUPPORT_SPL and FIT.. > And thanks for using the SUNXI_GEN_NCAT2 symbol, btw! > > One small thing below... > > > Add basic support for Allwinner A733 SoC. > > > > - Include some basic register definitions > > - Introduce a new SUN60I A733 Kconfig option > > - Ssetup RVBAR register properly according to docs > > - Config max DDR size 16GB > > - Config SRAM 0x62000 for TF-A > > > > Signed-off-by: Yixun Lan <[email protected]> > > .. > > config SYS_BOARD > > default "sunxi" > > @@ -1186,6 +1199,7 @@ config SPL_STACK_R_ADDR > > default 0x4fe00000 if MACH_SUN50I > > default 0x4fe00000 if SUN50I_GEN_H6 > > default 0x4fe00000 if SUNXI_GEN_NCAT2 > > + default 0x4fe00000 if MACH_SUN60I_A733 > > This is not needed, since the same address is already selected by NCAT2. > will drop it -- Yixun Lan (dlan)
