Hello Yannic, Am Donnerstag, dem 14.08.2025 um 14:05 +0200 schrieb Yannic Moog: > OP-TEE configs are enabled by default, change the doc to no longer > declare OP-TEE as optional. > Further, phycore-imx8mm and imx8mm-phygate-tauri-l use different > build > instructions, so dissolve the common file for building OP-TEE. > While at it, introduce style changes where export commands are no > longer > used.
you do a lot of changes in this commit. The firmware version change is not mentioned in the commit message. I think it would be easier to follow your changes if you split the commit into multiple ones here. Kind Regards, Teresa > > Signed-off-by: Yannic Moog <[email protected]> > --- > board/phytec/phycore_imx8mm/MAINTAINERS | 1 - > doc/board/phytec/imx8mm-optee-build.rsti | 14 ---------- > doc/board/phytec/imx8mm-phygate-tauri-l.rst | 42 ++++++++++++++++++- > --------- > doc/board/phytec/phycore-imx8mm.rst | 43 > +++++++++++++++++++---------- > doc/board/phytec/phycore-imx8mp.rst | 41 ++++++++++++++----- > -------- > 5 files changed, 79 insertions(+), 62 deletions(-) > > diff --git a/board/phytec/phycore_imx8mm/MAINTAINERS > b/board/phytec/phycore_imx8mm/MAINTAINERS > index > 7631e1cb331b608335620d0db49104459f673d1d..58c5e2d0af9fe404a5995fecc96 > cdbaa5845f979 100644 > --- a/board/phytec/phycore_imx8mm/MAINTAINERS > +++ b/board/phytec/phycore_imx8mm/MAINTAINERS > @@ -9,6 +9,5 @@ F: configs/imx8mm-phygate-tauri-l_defconfig > F: configs/phycore-imx8mm_defconfig > F: doc/board/phytec/imx8mm-phygate-tauri-l.rst > F: doc/board/phytec/index.rst > -F: doc/board/phytec/imx8mm-optee-build.rsti > F: doc/board/phytec/phycore_imx8mm.rst > F: include/configs/phycore_imx8mm.h > diff --git a/doc/board/phytec/imx8mm-optee-build.rsti > b/doc/board/phytec/imx8mm-optee-build.rsti > deleted file mode 100644 > index > c83de5cc7cf4a0229cbd89f4c7d2bfd8448cb735..000000000000000000000000000 > 0000000000000 > --- a/doc/board/phytec/imx8mm-optee-build.rsti > +++ /dev/null > @@ -1,14 +0,0 @@ > -Build the OP-TEE binary (optional) > ----------------------------------- > - > -.. code-block:: bash > - > - $ git clone https://github.com/OP-TEE/optee_os.git > - $ cd optee_os > - $ make CFG_TEE_BENCHMARK=n \ > - CROSS_COMPILE=aarch64-linux-gnu- \ > - O=out/arm \ > - PLATFORM=imx-mx8mmevk \ > - CFG_TZDRAM_START=0x56000000 \ > - CFG_DDR_SIZE=0x80000000 \ > - CFG_UART_BASE=UART3_BASE > diff --git a/doc/board/phytec/imx8mm-phygate-tauri-l.rst > b/doc/board/phytec/imx8mm-phygate-tauri-l.rst > index > 0d9e1024f8c5300e91a3a4c18b2babd5853a0824..4dd82cd9785fa585ed216664a25 > f593d4e723dbb 100644 > --- a/doc/board/phytec/imx8mm-phygate-tauri-l.rst > +++ b/doc/board/phytec/imx8mm-phygate-tauri-l.rst > @@ -9,7 +9,7 @@ Quick Start > ----------- > > - Build the ARM Trusted firmware binary > -- Build the OP-TEE binary (optional) > +- Build the OP-TEE binary > - Get ddr firmware > - Build U-Boot > - Boot > @@ -21,23 +21,35 @@ Build the ARM Trusted firmware binary > > $ git clone > https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git > $ cd trusted-firmware-a > - $ export CROSS_COMPILE=aarch64-linux-gnu- > - $ export IMX_BOOT_UART_BASE=0x30880000 > - $ # with optee > - $ make PLAT=imx8mm BL32_BASE=0x56000000 SPD=opteed bl31 > - $ # without optee > - $ make PLAT=imx8mm bl31 > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + PLAT=imx8mm \ > + IMX_BOOT_UART_BASE=0x30880000 \ > + BL32_BASE=0xbe000000 \ > + SPD=opteed \ > + bl31 > > -.. include:: imx8mm-optee-build.rsti > +Build the OP-TEE binary > +----------------------- > + > +.. code-block:: bash > + > + $ git clone https://github.com/OP-TEE/optee_os.git > + $ cd optee_os > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + CFG_TEE_BENCHMARK=n \ > + O=out/arm \ > + PLATFORM=imx-mx8mm_phygate_tauri_l > > Get the ddr firmware > -------------------- > > .. code-block:: bash > > - $ wget > https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.23.bin > - $ chmod +x firmware-imx-8.23.bin > - $ ./firmware-imx-8.23.bin > + $ wget > https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin > + $ chmod +x firmware-imx-8.28-994fa14.bin > + $ ./firmware-imx-8.28-994fa14.bin > > Build U-Boot for SD card > ------------------------ > @@ -49,15 +61,17 @@ Copy binaries > > $ cp <TF-A dir>/build/imx8mm/release/bl31.bin . > $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin > - $ cp firmware-imx-8.23/firmware/ddr/synopsys/lpddr4*.bin . > + $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin > . > > Build U-Boot > ^^^^^^^^^^^^ > > .. code-block:: bash > > - $ make imx8mm-phygate-tauri-l_defconfig > - $ make flash.bin > + $ make -j $(nproc) > + CROSS_COMPILE=aarch64-linux-gnu- \ > + imx8mm-phygate-tauri-l_defconfig \ > + flash.bin > > Flash SD card > ^^^^^^^^^^^^^ > diff --git a/doc/board/phytec/phycore-imx8mm.rst > b/doc/board/phytec/phycore-imx8mm.rst > index > 08f5949e02d8d2bfba71867d93c2b3ed8fdc67e2..d5edbc91474e95f677dd12e5fcc > 6c16092dea1cd 100644 > --- a/doc/board/phytec/phycore-imx8mm.rst > +++ b/doc/board/phytec/phycore-imx8mm.rst > @@ -9,7 +9,7 @@ Quick Start > ----------- > > - Build the ARM Trusted firmware binary > -- Build the OP-TEE binary (optional) > +- Build the OP-TEE binary > - Get ddr firmware > - Build U-Boot > - Boot > @@ -21,23 +21,35 @@ Build the ARM Trusted firmware binary > > $ git clone > https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git > $ cd trusted-firmware-a > - $ export CROSS_COMPILE=aarch64-linux-gnu- > - $ export IMX_BOOT_UART_BASE=0x30880000 > - $ # with optee > - $ make PLAT=imx8mm BL32_BASE=0x56000000 SPD=opteed bl31 > - $ # without optee > - $ make PLAT=imx8mm bl31 > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + PLAT=imx8mm \ > + IMX_BOOT_UART_BASE=0x30880000 \ > + BL32_BASE=0x7e000000 \ > + SPD=opteed \ > + bl31 > > -.. include:: imx8mm-optee-build.rsti > +Build the OP-TEE binary > +----------------------- > + > +.. code-block:: bash > + > + $ git clone https://github.com/OP-TEE/optee_os.git > + $ cd optee_os > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + CFG_TEE_BENCHMARK=n \ > + O=out/arm \ > + PLATFORM=imx-mx8mm_phyboard_polis > > Get the ddr firmware > -------------------- > > .. code-block:: bash > > - $ wget > https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.19.bin > - $ chmod +x firmware-imx-8.19.bin > - $ ./firmware-imx-8.19.bin > + $ wget > https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin > + $ chmod +x firmware-imx-8.28-994fa14.bin > + $ ./firmware-imx-8.28-994fa14.bin > > Build U-Boot for SD card > ------------------------ > @@ -48,15 +60,18 @@ Copy binaries > .. code-block:: bash > > $ cp <TF-A dir>/build/imx8mm/release/bl31.bin . > - $ cp firmware-imx-8.19/firmware/ddr/synopsys/lpddr4*.bin . > + $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin > + $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin > . > > Build U-Boot > ^^^^^^^^^^^^ > > .. code-block:: bash > > - $ make phycore-imx8mm_defconfig > - $ make flash.bin > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + phycore-imx8mm_defconfig \ > + flash.bin > > Flash SD card > ^^^^^^^^^^^^^ > diff --git a/doc/board/phytec/phycore-imx8mp.rst > b/doc/board/phytec/phycore-imx8mp.rst > index > 50be99126537a2dc5323bd49c1513b196182c5f3..cea3a2835e69d6c6d3aa4c16698 > aebd09f73bf49 100644 > --- a/doc/board/phytec/phycore-imx8mp.rst > +++ b/doc/board/phytec/phycore-imx8mp.rst > @@ -3,13 +3,13 @@ > phyCORE-i.MX 8M Plus > ==================== > > -The phyCORE-i.MX 8M Plus with 2GB of main memory is supported. > +The phyCORE-i.MX 8M Plus with 1,2,4GB of main memory is supported. > > Quick Start > ----------- > > - Build the ARM Trusted firmware binary > -- Build the OP-TEE binary (optional) > +- Build the OP-TEE binary > - Get ddr firmware > - Build U-Boot > - Boot > @@ -21,12 +21,13 @@ Build the ARM Trusted firmware binary > > $ git clone > https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git > $ cd trusted-firmware-a > - $ export CROSS_COMPILE=aarch64-linux-gnu- > - $ export IMX_BOOT_UART_BASE=0x30860000 > - $ # with optee > - $ make PLAT=imx8mp SPD=opteed bl31 > - $ # without optee > - $ make PLAT=imx8mp bl31 > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + PLAT=imx8mp \ > + IMX_BOOT_UART_BASE=0x30860000 \ > + BL32_BASE=0x7e000000 \ > + SPD=opteed \ > + bl31 > > Build the OP-TEE binary (optional) > ---------------------------------- > @@ -35,20 +36,20 @@ Build the OP-TEE binary (optional) > > $ git clone https://github.com/OP-TEE/optee_os.git > $ cd optee_os > - $ make CFG_TEE_BENCHMARK=n \ > - CROSS_COMPILE=aarch64-linux-gnu- \ > - O=out/arm \ > - PLATFORM=imx-mx8mp_phyboard_pollux \ > - CFG_TZDRAM_START=0x56000000 > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + CFG_TEE_BENCHMARK=n \ > + O=out/arm \ > + PLATFORM=imx-mx8mp_phyboard_pollux > > Get the ddr firmware > -------------------- > > .. code-block:: bash > > - $ wget > https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.19.bin > - $ chmod +x firmware-imx-8.19.bin > - $ ./firmware-imx-8.19.bin > + $ wget > https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.28-994fa14.bin > + $ chmod +x firmware-imx-8.28-994fa14.bin > + $ ./firmware-imx-8.28-994fa14.bin > > Build U-Boot for SD card > ------------------------ > @@ -60,15 +61,17 @@ Copy binaries > > $ cp <TF-A dir>/build/imx8mp/release/bl31.bin . > $ cp <OP-TEE dir>/out/arm/core/tee-raw.bin tee.bin > - $ cp firmware-imx-8.19/firmware/ddr/synopsys/lpddr4*.bin . > + $ cp firmware-imx-8.28-994fa14/firmware/ddr/synopsys/lpddr4*.bin > . > > Build U-Boot > ^^^^^^^^^^^^ > > .. code-block:: bash > > - $ make phycore-imx8mp_defconfig > - $ make flash.bin > + $ make -j $(nproc) \ > + CROSS_COMPILE=aarch64-linux-gnu- \ > + phycore-imx8mp_defconfig \ > + flash.bin > > Flash SD card > ^^^^^^^^^^^^^ > -- PHYTEC Messtechnik GmbH | Barcelona-Allee 1 | 55129 Mainz, Germany Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber, Dipl.-Ing. (FH) Markus Lickes | Handelsregister Mainz HRB 4656 | Finanzamt Mainz | St.Nr. 26/665/00608, DE 149059855
