On 2020/12/26 18:39, Denis Fondras wrote: > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h to avoid breaking base too much. > > > > they will > > > > be removed as soon as diff 2,3,4,5,6,7 are commited. > > > > > > We'll need to run a ports bulk build without the aliases. (I can > > > do that.) There will be some breakage. > > > > NetBSD and Solaris both provide SIMPLEQ_* and STAILQ_*. I'm not sure > > removing one in favour of the other is helpful. > > > > The "problem" is OpenBSD does not provide STAILQ_*. This difference forces > OpenBSD porters to patch linux/freebsd-centered programs. > NetBSD added STAILQ_* following FreeBSD. >
Adding STAILQ_* as an alternative might help the odd port. (It might conceivably also result in a duplicate macro somewhere and break something, though that should generally be easy to fix). Removing the SIMPLEQ names feels like a step too far. These are old macros, quite widely used in various projects, many of whom have taken them from OpenBSD (poke around on Debian codesearch, you'll see various copies with niallo or angelos in rcsid). They're often behind the same _SYS_QUEUE_H_ include guard that we use, I have a feeling they'll be quite annoying to workaround.
