Denis Fondras <[email protected]> wrote: > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit : > > > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify > > > > with FreeBSD and Linux. > > > > > > > > I added aliases at the end of queue.h to avoid breaking base too much. > > > > they will > > > > be removed as soon as diff 2,3,4,5,6,7 are commited. > > > > > > We'll need to run a ports bulk build without the aliases. (I can > > > do that.) There will be some breakage. > > > > NetBSD and Solaris both provide SIMPLEQ_* and STAILQ_*. I'm not sure > > removing one in favour of the other is helpful. > > > > The "problem" is OpenBSD does not provide STAILQ_*. This difference forces > OpenBSD porters to patch linux/freebsd-centered programs. > NetBSD added STAILQ_* following FreeBSD.
But your diffs do not stop after adding STAILQ_ You didn't stop after fixing the problem. You are planning on deleting SIMPLEQ_, and thus you are creating a new problem. And it is all in one spray of diffs. I am very skeptical about the diff to queue.h as it is a mix of tab/spaces, churns the old chunk, and makes a plan to delete SIMPLEQ_.
