On Wed, Jun 10, 2020 at 05:38:36PM +1000, Jonathan Gray wrote: > On Wed, Jun 10, 2020 at 09:19:47AM +0200, Martin Pieuchot wrote: > > On 09/06/20(Tue) 20:19, jo...@armadilloaerospace.com wrote: > > > Looking for some guidance to avoid proposing any unpopular diffs. > > > > > > Style(9) says not to use static on file-local functions in the > > > kernel, because it interferes with the debugger. They still show up > > > on some functions today; is this still an issue? > > > > I don't know if it's an issue, but not using 'static' is still a > > convention. > > It is. Backtraces in drm code aren't as useful as they could be as > static is extensively used. > > One annoying thing in C is that keywords are grossly overloaded.
If static and static were two different keywords, you could just #define static and be done with it. (are there any static variables in the drm code ?...)
