Looking for some guidance to avoid proposing any unpopular diffs.
Style(9) says not to use static on file-local functions in the
kernel, because it interferes with the debugger. They still show up
on some functions today; is this still an issue?
I usually advocate for directly inlining small functions that are only
called from one place, because it removes any doubt about whether it
is or ever should be called elsewhere. For instance, these functions:
vaddr_t
efifb_early_map(paddr_t pa)
{
return pmap_set_pml4_early(pa);
}
void
efifb_early_cleanup(void)
{
pmap_clear_pml4_early();
}
Is that frowned on? I know I am on the longer-functions side of
the spectrum.
Also, style(9) says that prototypes should not have variable names
associated with the types. I try to use good names in the headers
for documentation purposes; what is the thinking behind the rule?
int pcdisplay_copycols(void *id, int row, int srccol, int dstcol, int
ncols);
vs:
int pcdisplay_copycols(void *, int, int, int,int);
