> I've now gone back and forth on this diff a few times. I like the > simplfication of allocpid(), but then it seems like deck-chair shuffling > as the test is just moved to another function.
To me, it also feels like deckchair rearrangement. A special startup case condition (pid 1, and pid 0 to be honest) is handled at a particular point in the callgraph, and I don't see the point of pushing it upwards. The refactor does not seem more clear to me. > But eliminating the magic-at-a-distance randompid frobbing is nice, as is > making it clear that there's really only one PID that will ever be > special. Indeed, it would even allow kthreads to be created before init > (though what _else_ they depend on is unclear...). Maybe setting the USB > tasks loose earlier would be useful, for example. Hmm. If the usage cases were proven first...
