On Sun, 5 Feb 2017, Ossi Herrala wrote: > init(8) is wanted to have process ID 1. It's also the only process which > is assigned non-random PID (well, there's also swapper as PID 0). > > This patch renames fork1() to fork1_to_pid() and introduces new argument > "pid" which can be used to select PID for new process. When pid is 0, > random PID is assigned. fork1() is then wrapper to fork1_to_pid() with > pid argument being 0. No functional change in fork1().
I wouldn't have a problem with this diff...except it adds a *ninth* argument to a function. fork1() is already really bad with eight arguments: we need to break up its uses and refactor it to be less confusing and overloaded and not add Yet Another Argument With Magic Value. Philip Guenther
