On Mon, Aug 01, 2016 at 04:14:54PM -0500, joshua stein wrote: > are these complaints really helpful on modern machines? > >
Please do not DEBUG these. They are useful for me when testing vmm, since presently I have neither the nvram or clock laid out right. We can remove these once I get the mc146818 emulation complete. -ml > Index: arch/amd64/amd64/nvram.c > =================================================================== > RCS file: /cvs/src/sys/arch/amd64/amd64/nvram.c,v > retrieving revision 1.6 > diff -u -p -u -p -r1.6 nvram.c > --- arch/amd64/amd64/nvram.c 6 Mar 2016 22:41:24 -0000 1.6 > +++ arch/amd64/amd64/nvram.c 1 Aug 2016 21:13:09 -0000 > @@ -64,8 +64,11 @@ nvramattach(int num) > printf("nvram: initialized\n"); > #endif > nvram_initialized = 1; > - } else > + } > +#ifdef NVRAM_DEBUG > + else > printf("nvram: invalid checksum\n"); > +#endif > } > > int > Index: arch/amd64/isa/clock.c > =================================================================== > RCS file: /cvs/src/sys/arch/amd64/isa/clock.c,v > retrieving revision 1.22 > diff -u -p -u -p -r1.22 clock.c > --- arch/amd64/isa/clock.c 14 Mar 2015 03:38:46 -0000 1.22 > +++ arch/amd64/isa/clock.c 1 Aug 2016 21:13:09 -0000 > @@ -428,7 +428,7 @@ clock_expandyear(int clockyear) > cmoscentury = 0; > splx(s); > if (!cmoscentury) { > -#ifdef DIAGNOSTIC > +#ifdef DEBUG_CLOCK > printf("clock: unknown CMOS layout\n"); > #endif > return (clockyear); >