> Am 01.08.2016 um 23:14 schrieb joshua stein <j...@openbsd.org>:
>
> are these complaints really helpful on modern machines?
Can't speak for clock. But I tend to not like this for nvram.
IMHO, even with recent HW this is a valid concern and reminder
that someone should handle setting of the nvram options correctly.
> Index: arch/amd64/amd64/nvram.c
> ===================================================================
> RCS file: /cvs/src/sys/arch/amd64/amd64/nvram.c,v
> retrieving revision 1.6
> diff -u -p -u -p -r1.6 nvram.c
> --- arch/amd64/amd64/nvram.c 6 Mar 2016 22:41:24 -0000 1.6
> +++ arch/amd64/amd64/nvram.c 1 Aug 2016 21:13:09 -0000
> @@ -64,8 +64,11 @@ nvramattach(int num)
> printf("nvram: initialized\n");
> #endif
> nvram_initialized = 1;
> - } else
> + }
> +#ifdef NVRAM_DEBUG
> + else
> printf("nvram: invalid checksum\n");
> +#endif
> }
>
> int
> Index: arch/amd64/isa/clock.c
> ===================================================================
> RCS file: /cvs/src/sys/arch/amd64/isa/clock.c,v
> retrieving revision 1.22
> diff -u -p -u -p -r1.22 clock.c
> --- arch/amd64/isa/clock.c 14 Mar 2015 03:38:46 -0000 1.22
> +++ arch/amd64/isa/clock.c 1 Aug 2016 21:13:09 -0000
> @@ -428,7 +428,7 @@ clock_expandyear(int clockyear)
> cmoscentury = 0;
> splx(s);
> if (!cmoscentury) {
> -#ifdef DIAGNOSTIC
> +#ifdef DEBUG_CLOCK
> printf("clock: unknown CMOS layout\n");
> #endif
> return (clockyear);
>
