On Tue, Feb 25, 2014 at 03:08:48PM -0500, Ted Unangst wrote: > Tangent: > > I don't like the style used for the delay loops in azalia.c. > > 1. There's an off by one where 0 passes both conditionals. It's > unlikely this matters, but it's needless inconsistency. > 2. I think i <= 0 is a dangerous idiom because any code refactor that > changes the variable in question to unsigned introduces an infinite > loop. > > This can wait til after 5.5, but I made the diff since I was looking > at the code.
ok ratchov
