On Tue, Feb 25, 2014 at 15:08, Ted Unangst wrote:
> Tangent:
> 
> I don't like the style used for the delay loops in azalia.c.
> 
> 1. There's an off by one where 0 passes both conditionals. It's
> unlikely this matters, but it's needless inconsistency.
> 2. I think i <= 0 is a dangerous idiom because any code refactor that
> changes the variable in question to unsigned introduces an infinite
> loop.

Sorry, stupid typo. I'm concerned about the loop conditional, i >= 0.

Reply via email to