Hey Vladimir, On 07/02/13(Thu) 17:02, Vladimir Támara Patiño wrote: > Attached is a .tar.gz with 49 news files to place in /usr/src and > below there is a patch for /usr/src of OpenBSD 5.2 that modifies > 53 files to integrate the collation support of the xlocale implementation of > FreeBSD (POSIX 2008). If there is interest I can try to update it > to current in next days.
That's cool stuff but I totally agree with stsp@ here, your diff is way too big to be correctly reviewed and integrated. So to answer your first question, yes please update to -current and make sure you have the last version of the sources you're generating your diff against. > [...] > * Still refactoring is needed, if needed I can try to write > documentation in english of key points of the integration. I'd suggest you to submit smaller diffs that may be integrated progressively instead of writing a "how to integrate this huge diff" document ;) This will also help to find a solution for the various FIXME left in your code. Apart from that, make sure your inline diffs does not get mangled by you mail program so that they can be apply. Martin