C-N and C-P are already assigned to forward-line and backward-line in dired.c I don't think it's a good idea to remap existing key-bindings...
On Sun, Jul 31, 2011 at 11:32 PM, Nima Hoda <nimah...@gmail.com> wrote: > On Sun, Jul 31, 2011 at 12:15:56PM -0600, Theo de Raadt wrote: > > > I tested the patch briefly and it seems to work fine BUT I'm not sure > > > why this is a good idea. You're mapping keys that do other things in > > > Emacs (esp. C-o but also C-t and even C-w which can be used if the > > > dired buffer is made non-read-only in Emacs). > > > > When the change is simple, mg should behave like emacs. > > > > Sometimes it will be different because it is a simpler editor. But > > it should not go out of the way to be different. > > Yeah, this doesn't seem like a difference due to simplicity. It would > be just as simple to wrap next-line and previous-line to replicate the > Emacs behaviour. > > Cheers, > -Nima > -- > The pudding is in the proof. > -- `` Real men run current !''
