On Sun, Jun 19, 2011 at 03:21:49AM -0600, Theo de Raadt wrote:
> From reading the other drivers, I can tell immediately that this is
> wrong.
>
> And it locks machines up.
Is this better then?
If it is what I think you're referring to then is what was commited to azalia(4)
and em(4) also wrong?
Index: if_bnx.c
===================================================================
RCS file: /home/cvs/src/sys/dev/pci/if_bnx.c,v
retrieving revision 1.94
diff -u -p -r1.94 if_bnx.c
--- if_bnx.c 18 Apr 2011 04:27:31 -0000 1.94
+++ if_bnx.c 19 Jun 2011 15:21:19 -0000
@@ -668,7 +668,7 @@ bnx_attach(struct device *parent, struct
return;
}
- if (pci_intr_map(pa, &sc->bnx_ih)) {
+ if (pci_intr_map_msi(pa, &sc->bnx_ih) != 0 && pci_intr_map(pa,
&sc->bnx_ih) != 0) {
printf(": couldn't map interrupt\n");
goto bnx_attach_fail;
}
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
