On Thu, Nov 25, 2010 at 11:50 AM, Claudio Jeker <cje...@diehard.n-r-g.com> wrote: > On Wed, Nov 24, 2010 at 05:42:59PM +0100, Mike Belopuhov wrote: >> On Wed, Nov 24, 2010 at 17:06 +0100, Claudio Jeker wrote: >> > This diff was made by oga@ some time ago -- I just fixed a few conflicts >> > and I would really like to see this going in. >> > >> > netisr needs to be made a normal C function and not this madness it >> > currently is. This is necessary to imporve the packet scheduling. >> > >> > Tested myself on i386, amd64, sparc64, sparc, alpha and hppa >> >> hi, >> >> i like the diff, but why not get rid of netisr_dispatch.h? > > I planned to this after this diff goes in. I did not want to change > Owain's initial diff too much so I left that out for now. >
i don't see a reason to wait, but ymmv. >> also i'm not sure, but maybe netisr.c copyright should be >> attributed to berkeley as we're using their code directly? > > Are we? > actually, this is netbsd code in part. i've traced it to the Eric Haszlakiewicz's <e...@netbsd> commit to sys/arch/sparc/sparc/intr.c [1] and he also introduced netisr_dispatch.h include. unfortunately he's not mentioned in any copyrights. maybe our derived work is a bit different, so we shouldn't bother. > -- > :wq Claudio
