Thordur I Bjornsson writes:

> > -Where necessary, produce "human-readable" output.
> > +Where necessary, produce ``human-readable'' output.
>
> Why is this better ? (I'm not a native english speaker, so I'm genuinely 
> asking)

It's not better per se; it's just consistent with the quote style in the
rest of the man page.

> > -# dd if=/dev/zero of=/dev/rsd3c bs=1m count=1
> > +# dd if=/dev/zero of=/dev/rsd2c bs=1m count=1
>
> This is probably done on purpose to prevent people from copy/pasting
> commands out of the man page.

Sure. I don't feel strongly about this change. But, I thought that it is
better to be consistent with the immediately preceding and postceding
examples, which operate on sd2. The three examples, when they all use the
same device, could potentially be part of a realistic command sequence: set
it up with CRYPTO discipline... zero out the beginning... do stuff with
it... detach it.

Also, especially with sd* devices, there is a tricky thing where if you plug
in a USB disk (e.g. sd0) when you put a softraid on it, you'll newfs and
mount it as sd1*. I imagined that people might confuse this sd2 -> sd3
example with the increment-device-id-by-1 behavior that is natural to
putting softraid devices on sd devices. That particular thing didn't trip me
up, but I imagined that it could trip someone else up.

Another possible change would be to consistently use completely different
devices, like wd5, sd7, sd0, et c.

> > +(Note that RAID is also the correct partition type when using the CRYPTO
> > +discipline.)
>
> Having this note in parentheses is pretty ugly IMO.

Removing the parens would be fine by me.


-- 
http://noncombatant.org/

Reply via email to