On 2 August 2017 at 01:49, Dirk Hohndel <[email protected]> wrote: > > Nice. I would love to be able to see if this could be made to work with > Qt 5.7 (or even better 5.6) - otherwise we are leaving a lot of distributions > behind. Requiring 5.9 is no problem for Windows and Mac, but for the > various Linux distros (about 20% or so of our users) it's a no go. Most > are not even on 5.8 at this point.
i quickly browsed the source and i can't find some of those new 5.9 signals that were breaking the build with Qt 5.7. maybe you can try building the plugin with the older Qt? > Lubomir, are you going to send a PR for this? What are the next steps? > in my previous email i included a patch which is enough to enable this on the subsurface side (attaching again). but...this has to be decided i guess (i.e. how are we going to build this plugin): > we have some options with this: > - include this plugin's source into the Subsurface repository > it's qmake based so it needs a cmake port (or does it?). this would > allow us to build it everytime Subsurface is built. > - fork it as a Subsurface github organization project > this means that the source needs to be pulled and build using build.sh. > > for both cases i'm not sure about the deployment process. right now > i'm manually copying a DLL inside the Qt-HOME/plugins/geoservices > folder. > lubomir --
From 5cb1d28861437172887952db447f324aa56ce8a4 Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov" <[email protected]> Date: Wed, 2 Aug 2017 00:51:09 +0300 Subject: [PATCH] mapwidget.qml: use a custom built googlemaps plugin This patch makes use of the geolocation plugin "googlemaps" for Qt Location with source code from here: https://github.com/vladest/googlemaps The change from the ESRI plugin is that it requires new indexes for the Hybrid ([3]) and Street ([0]) map types. There are more zoom levels in this plugins, but our default zoom-in settings seem to transition well to it. Signed-off-by: Lubomir I. Ivanov <[email protected]> --- mobile-widgets/qml/MapWidget.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mobile-widgets/qml/MapWidget.qml b/mobile-widgets/qml/MapWidget.qml index 28975ee..3c948a3 100644 --- a/mobile-widgets/qml/MapWidget.qml +++ b/mobile-widgets/qml/MapWidget.qml @@ -9,7 +9,7 @@ Item { Plugin { id: mapPlugin - name: "esri" + name: "googlemaps" } MapWidgetHelper { @@ -27,7 +27,7 @@ Item { plugin: mapPlugin zoomLevel: 1 - readonly property var mapType: { "STREET": supportedMapTypes[0], "SATELLITE": supportedMapTypes[1] } + readonly property var mapType: { "STREET": supportedMapTypes[0], "SATELLITE": supportedMapTypes[3] } readonly property var defaultCenter: QtPositioning.coordinate(0, 0) readonly property real defaultZoomIn: 12.0 readonly property real defaultZoomOut: 1.0 -- 1.7.11.msysgit.0
_______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
