On 27 July 2017 at 19:26, Lubomir I. Ivanov <[email protected]> wrote: > On 23 July 2017 at 04:13, Lubomir I. Ivanov <[email protected]> wrote: >> On 23 July 2017 at 03:58, Dirk Hohndel <[email protected]> wrote: >>> I don't know if I asked before... can the flags be labeled? Dive site name? >>> >> >> yes, i will add the labels soon. >> > > so, everything is pretty much in place including editing. i just need > an answer for the bellow question and to rebase my few last patches. > > the question is for Dirk and Linus about this particular logic here: > https://github.com/neolit123/subsurface/blob/master/desktop-widgets/globe.cpp#L220 > maybe Tomaz is interested in this too. > > the Q is - shouldn't this skipping of dive sites which are too close > to already added dives sites (as markers) with the same name happen at > the backend? > - i.e. when parsing / creating the dive site list such can be merged? > there is already the infrastructure for that e.g. > divesite.h:get_distance(), divesite.h:merge_dive_sites()/ > > in my opinion the number of map marks should match the number of dive > sites on the frontend side. >
ATM for marble the following happens: - clicking dives with nearby divesites creates a jumping effect because the current dive site is displayed and the nearby divesite with the same name is discarded. https://gifyu.com/images/marble_jumping_markers.gif - it imposes the architecture where the whole list of markers has to be re-created on selecting a new dive. this can end up being very slow for thousands of dives. lubomir -- _______________________________________________ subsurface mailing list [email protected] http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
