Hello Suresh,
On Saturday, May 08, 2004, Suresh Ramasubramanian wrote...

> The "display preferences" link in options

> https://webmail.hserus.net/src/options.php?optpage=display
> produces error -

> Fatal error: Call to a member function on a non-object in
> /home/suresh/public_html/squirrelmail/include/options/display.php on line
> 26

> I can reproduce the bug by:

> Clicking the "display preferences" link in options

> (Optional) I got bored and found the bug occurs in:

> include/options/display.php

> That line seems to call "theme.php" -

>             if (is_dir($dirName."/".$dir) &&
> file_exists("$dirName/$dir/theme.php"))
>                 include("$dirName/$dir/theme.php");

> which doesn't exist.

Erm... can you check what version of that file you're using... That
line doesn't seem right.  My line 26 lists:

  while($dir = $d->read()) {

This is something different from what you are showing, which is about
2 lines further down... The code you mentioned should be safe as it's
just testing a name is a folder, and a file does exist under it... if
it is, then it includes it... nothing bad there. Now the bit that
could fail is that the line above the one I mention could fail, there
doesn't seem any checks on its success... so it could be that it fails
there, and the dir function doesn't work as expected then... Shall
test that scenario.

-- 
Jonathan Angliss
([EMAIL PROTECTED])

Posting Hints: http://article.gmane.org/gmane.mail.squirrelmail.user/16718



-------------------------------------------------------
This SF.Net email is sponsored by Sleepycat Software
Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to 
deliver higher performing products faster, at low TCO.
http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
--
squirrelmail-users mailing list
List Address: [EMAIL PROTECTED]
List Archives:  http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Reply via email to